[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Comprehensive JSX support in Emacs
From: |
Dmitry Gutov |
Subject: |
Re: Comprehensive JSX support in Emacs |
Date: |
Fri, 15 Feb 2019 17:39:22 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Thunderbird/65.0 |
Hi Jackson,
On 14.02.2019 08:06, Jackson Ray Hamilton wrote:
Recently, I finally resolved to “do my laundry,” with respect to
addressing the JSX indentation issues accumulated within debbugs and the
js2-mode GitHub repo (where lots of js-mode bugs accidentally get
filed). In the past week, I assembled some test cases, drafted some
algorithms, and proceeded to implement a number of improvements to the
indentation logic.
Thanks a lot for working on this.
On my part, I can say I'm excited about indentation improvements.
Creating jsx-specific variables that default to sgml- values sounds good.
Regarding js?-jsx- mode deprecations, I'm ambivalent. The current design
seems okay from my POV, that the thing Flycheck ends up having to do is
not the end of the world (there are several major modes in that list
already anyway). But if other people agree, all the best. I'd just
prefer not to turn it on by default, in the absence of any indications
that the current file is JSX.