emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/fix-33794-extend-electric-layout-mode 41a9132:


From: João Távora
Subject: Re: [Emacs-diffs] scratch/fix-33794-extend-electric-layout-mode 41a9132: Extend electric-layout-mode to handle more complex layouts
Date: Fri, 28 Dec 2018 16:33:52 +0000

On Sat, Dec 22, 2018 at 9:23 PM João Távora <address@hidden> wrote:
> Stefan Monnier <address@hidden> writes:
>
> >> +            ('after-stay (save-excursion
> >> +                           (let ((electric-layout-rules nil)
> >> +                                 
> >> (electric-pair-open-newline-between-pairs nil))
> >> +                             (newline 1 t))))
> >
> > I think the above let-binding of
> > electric-pair-open-newline-between-pairs deserves a FIXME as well,
> > because electric-layout-mode should ideally not need to know such
> > details of about electric-pair-mode.
>
> Done.  Indeed, as I described in the fixme
> electric-pair-open-newline-between-pairs is really a question of layout
> (not pairing) and thus a responsibility of e-l-m, but its API is not
> powerful enough yet to detect the exact situation yet.  So it seems
> reasonable for now to do this, especially since
> electric-pair-open-newline-between-pairs is a part of e-p-m's external
> interface.

Stefan, did you have a look at the most recent version
of this branch? (I rebased it meanwhile) I'd like to
land it in master. e-l-m's API is should now be good
enough to make electric-pair-open-newline-between-pairs
its responsibility.

João



reply via email to

[Prev in Thread] Current Thread [Next in Thread]