emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: display-buffer-use-some-frame


From: martin rudalics
Subject: Re: display-buffer-use-some-frame
Date: Wed, 12 Dec 2018 09:31:49 +0100

>> - In the call
>>
>>            (window--display-buffer
>>             buffer window 'frame alist display-buffer-mark-dedicated)
>>
>>    you should write 'reuse instead of 'frame.  The latter means that a
>>    new frame has been made but you just reuse an existing window.  I
>>    noticed this because I made the same error in (an undocumented part
>>    of) 'display-buffer-in-child-frame'.
>
> I'll fix this after the test below.

Fine.

>> Also, I wonder why you call
>> 'frame-first-window' here:
>>
>>                             (not (window-dedicated-p
>>                                   (or
>>                                    (get-lru-window frame)
>>                                    (frame-first-window frame)))))
>
> I don't remember. I'll test for a while without it.

Please do that.

Thanks, martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]