Re: Identifying the face between STRETCH and right fringe.

[Eli Zaretskii]

> From: Robert Pluim <address@hidden>
> Cc: address@hidden
> Date: Wed, 28 Nov 2018 09:36:53 +0100
> 
> Eli Zaretskii <address@hidden> writes:
> 
> >> From: Robert Pluim <address@hidden>
> >> Cc: address@hidden
> >> Date: Tue, 27 Nov 2018 20:14:14 +0100
> >> 
> >> >> > Why does NS use indices here, and not RGBA values?
> >> >> 
> >> >> Probably because NS doesnʼt really use the RGBA values directly at
> >> >> all, but uses the indices all the time.
> >> >
> >> > So where does the RGBA value in FRAME_BACKGROUND_PIXEL come from?
> >
> > Can you answer this question?
> 
> Itʼs set by the NS version of x_set_background_color, so itʼs correct,
> just not the same format as the face background colour.

So they call ns_lisp_to_color once and store the result?

I still wonder why they don't do this with other face colors.  Is
ns_lisp_to_color expensive or something?

> >> -      && face->background == FRAME_BACKGROUND_PIXEL (f)
> >> +      && FACE_COLOR_TO_PIXEL(face->background, f) == 
> >> FRAME_BACKGROUND_PIXEL (f)
> >                                ^
> > Please leave one space between the macro name and the opening paren.
> 
> Fixed (plus a missing space at the end of a comment sentence).

Thanks.