emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour


From: Thomas Fitzsimmons
Subject: Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour
Date: Mon, 17 Sep 2018 20:29:24 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> +  ;; Just return nil if there is no advice, rather than signaling an
>> +  ;; error.
>> +  (condition-case nil
>> +      (ad-remove-advice symbol 'around function)
>> +    (error nil))
>> +  (condition-case nil
>> +      (ad-activate symbol)
>> +    (error nil)))
>
> BTW, I just pushed a change which adds support for advice-member-p and
> changes the above code to make use of it, in order to silence
> fewer errors.
>
> It works in my tests, but could you check that it still works for you?

Confirmed still working, thanks.

Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]