emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Introducing thread-safe Tramp


From: Eli Zaretskii
Subject: Re: Introducing thread-safe Tramp
Date: Sat, 04 Aug 2018 18:00:01 +0300

> From: Michael Albinus <address@hidden>
> Cc: address@hidden,  address@hidden,  address@hidden
> Date: Sat, 04 Aug 2018 14:49:35 +0200
> 
> Michael Albinus <address@hidden> writes:
> 
> > What about the appended patch for the feature/tramp-thread-safe branch?
> > It introduces "C-x &" as prefix argument, toggling the meaning of
> > the `find-file-asynchronously' variable.
> 
> Now with patch.

The command's name should be more general, as I believe this was
envisaged to eventually become effective for more commands than those
which visit files?

> +    ;; `read-key-sequence' ignores quit, so make an explicit check.
> +    ;; Like many places, this assumes quit == C-g, but it need not be.
> +    (if (equal last-input-event ?\C-g)

Why not use current-input-mode here?

> +      ;; This is the final call to `universal-argument-other-key', which
> +      ;; set's the final `prefix-arg.
            ^^^^^
"sets"

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]