Re: bignum branch

[Andy Moreton]

On Fri 03 Aug 2018, Eli Zaretskii wrote:

>> From: Andy Moreton <address@hidden>
>> Date: Fri, 03 Aug 2018 11:07:06 +0100
>> 
>> On the bignum ranch for 32bit MinGW I get:
>> 
>> make -C lib all
>> make[1]: Entering directory `/c/emacs/git/emacs/bignum/build/mingw32/lib'
>>   CC       gettimeofday.o
>> In file included from c:/emacs/git/emacs/bignum/lib/gettimeofday.c:23:0:
>> c:/emacs/git/emacs/bignum/nt/inc/sys/time.h:11:19: error: field 
>> 'it_interval' has incomplete type
>>    struct  timeval it_interval; /* timer interval */
>>                    ^~~~~~~~~~~
>> c:/emacs/git/emacs/bignum/nt/inc/sys/time.h:12:19: error: field 'it_value' 
>> has incomplete type
>>    struct  timeval it_value; /* current value */
>>                    ^~~~~~~~
>> c:/emacs/git/emacs/bignum/lib/gettimeofday.c:64:1: error: conflicting types 
>> for 'gettimeofday'
>>  gettimeofday (struct timeval *restrict tv, void *restrict tz)
>>  ^~~~~~~~~~~~
>> In file included from c:/emacs/git/emacs/bignum/nt/inc/sys/time.h:4:0,
>>                  from c:/emacs/git/emacs/bignum/lib/gettimeofday.c:23:
>> c:\mingw\include\sys\time.h:108:29: note: previous declaration of 
>> 'gettimeofday' was here
>>  int __cdecl __MINGW_NOTHROW gettimeofday
>>                              ^~~~~~~~~~~~
>> c:/emacs/git/emacs/bignum/lib/gettimeofday.c: In function 'gettimeofday':
>> c:/emacs/git/emacs/bignum/lib/gettimeofday.c:100:5: error: dereferencing 
>> pointer to incomplete type 'struct timeval'
>>    tv->tv_sec = microseconds_since_1970 / (ULONGLONG) 1000000;
>>      ^~
>> make[1]: *** [gettimeofday.o] Error 1
>> make[1]: Leaving directory `/c/emacs/git/emacs/bignum/build/mingw32/lib'
>> make: *** [lib] Error 2
>
> Any idea how come these errors don't happen in the 64-bit MinGW64
> build?  They use the same headers, so what is different that triggers
> the errors only in the 32-bit build?

They don't happen in the 32bit MinGW (mingw.org) build on master either.

I assume that something got fixed on the master branch after the bignum
branch was created, and that the bignum branch has not been rebased
since then.

    AndyM