[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hoo
From: |
Eli Zaretskii |
Subject: |
Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents |
Date: |
Sat, 21 Jul 2018 21:35:53 +0300 |
> From: Stefan Monnier <address@hidden>
> Date: Sat, 21 Jul 2018 14:29:27 -0400
>
> > I don't understand your claims, sorry. Is the code wrong, or are the
> > comments wrong?
>
> I don't understand enough of the code to have an opinion on it, but the
> comments describe a behavior which would be wrong: both before-c-f and
> after-c-f- need to be run for any buffer change, even if it's only an
> insertion or only a deletion.
What if there's no change at all, i.e. no deletions and no insertions?
That was the OP's recipe.
> > And what would you expect to see in the buffer
> > modification hooks calls for the recipe of that bug?
>
> Lots of options, but basically: one call to b-c-f with FROM being < then
> the first position at which a deletion or insertion will take place and
> TO being after the last such position (e.g. from==to if the change is
> a single insertion); followed by one call to a-c-f with the
> same constraints (e.g. from==to if it's a single deletion).
You did read the bug report, didn't you? Because unless I completely
misunderstand what you are saying, you are not describing the bug's
recipe.
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Stefan Monnier, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Eli Zaretskii, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Stefan Monnier, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents,
Eli Zaretskii <=
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Stefan Monnier, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Eli Zaretskii, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Stefan Monnier, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Richard Stallman, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Eli Zaretskii, 2018/07/21
- Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents, Stefan Monnier, 2018/07/22