Re: netsec 682578f 4/6: Add option to bypass NSM TLS checks on local networks

[Eli Zaretskii]

> From: Robert Pluim <address@hidden>
> Cc: address@hidden
> Date: Mon, 16 Jul 2018 18:23:21 +0200
> 
> > No, you don't need anything special.  nt/inc/socket.h redirects
> > getaddrinfo into sys_getaddrinfo, and all our C sources see the
> > redirection.
> 
> Thanks. I always forget how the nt stuff works.

In general, all the sys_* stuff is invisible everywhere except in
w32.c.

> >> +  ret = getaddrinfo (SSDATA (name), NULL, &hints, &res);
> >
> > You should encode NAME (using ENCODE_SYSTEM), because it could include
> > non-ASCII characters.  In general, any Lisp string should be encoded
> > before you can pass its data to a C library function.
> >
> 
> My understanding is that this API only supports ASCII anyway.

Then I think we should test that it's either a unibyte string or a
string whose size in bytes is equal to its size in characters, and
signal an error if that doesn't hold.