emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 332f465: Make lisp/jsonrpc.el work with Emacs 2


From: Stefan Monnier
Subject: Re: [Emacs-diffs] master 332f465: Make lisp/jsonrpc.el work with Emacs 25.1
Date: Mon, 02 Jul 2018 22:40:18 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> -    (jsonrpc--debug connection `(:maybe-run-deferred ,(mapcar #'caddr 
> actions)))
> +    (jsonrpc--debug connection `(:maybe-run-deferred
> +                                 ,(mapcar (lambda (action) (car (cdr (cdr 
> action))))
> +                                          actions)))

`caddr` is available in cl-lib as cl-caddr.  This said I often find
(nth 2 ...) more readable.

> +(defun jsonrpc--call-with-emacsrpc-fixture (fn)
[...]
>  (cl-defmacro jsonrpc--with-emacsrpc-fixture ((endpoint-sym) &body body)
[...]
> +  `(jsonrpc--call-with-emacsrpc-fixture (lambda (,endpoint-sym) ,@body)))

Good change: much easier to debug.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]