emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Byte-compilation of custom themes


From: Basil L. Contovounesios
Subject: Re: Byte-compilation of custom themes
Date: Fri, 01 Jun 2018 22:07:24 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

"Basil L. Contovounesios" <address@hidden> writes:

> @@ -250,7 +250,7 @@ string-remove-prefix
>  (defsubst string-remove-suffix (suffix string)
>    "Remove SUFFIX from STRING if present."
>    (if (string-suffix-p suffix string)
> -      (substring string 0 (- (length string) (length suffix)))
> +      (substring string 0 (- (length suffix)))
>      string))

Running the new subr-x-test-string-remove-suffix revealed that there is
a bug here when the length of SUFFIX is equal to zero.  I reattach the
patches with this "simplification" reverted.  Sorry about the hassle.

Thanks,

-- 
Basil

Attachment: 0001-Improve-loading-of-byte-compiled-custom-themes.patch
Description: Text Data

Attachment: 0002-Disable-no-byte-compile-in-built-in-themes.patch
Description: Text Data

Attachment: 0003-Fix-custom-available-themes-file-expansion.patch
Description: Text Data

Attachment: 0004-lisp-custom.el-Use-lexical-binding.patch
Description: Text Data

Attachment: 0005-lisp-cus-theme.el-Use-lexical-binding.patch
Description: Text Data

Attachment: 0006-Minor-custom.el-simplifications.patch
Description: Text Data

Attachment: 0007-Minor-cus-theme.el-simplifications.patch
Description: Text Data

Attachment: 0008-Tweak-subr-x.el-substring-functions.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]