emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: package.el strings


From: Noam Postavsky
Subject: Re: package.el strings
Date: Thu, 26 Apr 2018 07:28:56 -0400

> I'm not sure I understand the question. This format call produces
> messages that are semantically equivalent to the original concat calls
> but the concat calls were not localizable so I changed them to something
> that we'll eventually be able to properly extract and localize.

I meant just the outer (format "%s%s%s%s" ...) vs (concat ...).  Is that
also needed to make strings localizable?  If yes, I think adding a
comment would be helpful, because it looks a bit unnatural to me.
 
>>> +                (message "Operation finished. Packages that are no longer 
>>> needed: %d. Type `%s' to remove them"

>> This line is getting pretty long, perhaps it should be broken up?
> 
> I guess you mean the line of code?

Yes.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]