Re: package.el strings

On Apr 26, 2018, at 10:10, Noam Postavsky <address@hidden> wrote:

Almost 9 months and nothing in master. Was there anything wrong with
the code?

I think the problem is more a lack of people who "make changes in
package.el". Although there's enough that your patch no longer applies
cleanly.

I thought so, but thank you for getting back to me.

error: patch failed: lisp/emacs-lisp/package.el:3262
error: lisp/emacs-lisp/package.el: patch does not apply

I'll fix the issues and will resubmit.

Some minor comments below.

+;; The terminating comment could be a generic string that is not in English
(unless (search-forward (concat ";;; " file-name ".el ends here"))
(error "Package lacks a terminating comment"))

Should that be a FIXME or TODO?

If we consider l10n and the function of this string, there is no reason this string should be in English (or in any native language for that matter). I don't know what that makes it. I'd say FIXME.

(defun package-menu--prompt-transaction-p (delete install upgrade)

+ (format "%s%s%s%s"

This kind of format call is that same as concat, right?

I'm not sure I understand the question. This format call produces messages that are semantically equivalent to the original concat calls but the concat calls were not localizable so I changed them to something that we'll eventually be able to properly extract and localize.

There are probably ways to use concat to produce localizable strings though.

+                (message "Operation finished. Packages that are no longer needed: %d. Type `%s' to remove them"
                                               ^                                       ^
                                               Double spacing                          Double spacing

This line is getting pretty long, perhaps it should be broken up?

I guess you mean the line of code?

From:	Jean-Christophe Helary
Subject:	Re: package.el strings
Date:	Thu, 26 Apr 2018 15:31:24 +0900