Re: master 51c8369: Run secrets suite test when Emacs has dbus support

[Tino Calancha]

On Fri, 6 Apr 2018, Tino Calancha wrote:

> > >     Run secrets suite test when Emacs has dbus support
> > >
> > >     * test/lisp/net/secrets-tests.el (secrets-test00-availability)
> > >     (secrets-test01-sessions, secrets-test02-collections)
> > >     (secrets-test03-items, secrets-test04-search): Skip test
> > >     unless Emacs is compiled with dbus support.
> >
> > Why this? If there is no D-Bus support, secrets-enabled shall be nil,
> > and the tests shall skip (except secrets-test00-availability, which
> > shall fail). That's intended.
> I don't know.  I saw in our gitlab CI that your new test was failing:
> https://gitlab.com/emacs-ci/emacs/commits/master
Just re-reading my answer looks unclear (even to me).  The reason why I 
skipped these tests if the feature 'dbusbind is not present was:

* After inspecting the gitlab log file I found this:

  ELC      lisp/net/secrets-tests.elc
peculiar error: "Emacs not compiled with dbus support"
Makefile:151: recipe for target 'lisp/net/secrets-tests.elc' failed
make[3]: *** [lisp/net/secrets-tests.elc] Error 255
make[3]: Target 'lisp/net/secrets-tests.log' not remade because of errors.

Best regards,
Tino