Re: Relics of removed dir-locals-file-2 feature in pretest

[Kaushal Modi]

On Wed, Nov 22, 2017 at 11:20 AM Eli Zaretskii <address@hidden> wrote:

So I really don't understand what is the issue that needs to be fixed.

OK, at the risk of sounding very stupid.. this feature was removed and then added again in this commit: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26&id=da976cff352bdea6adc2667582a56eb4061bb5f6

Right?

The defconst dir-locals-file-2 is added in that commit, but is not used anywhere.

Looking at the dir-locals--all-files code in that commit, from what I understand, the let-bound file-2 derivation is hard-coded, and has nothing to do with dir-locals-file-2:

           (file-2 (when (string-match "\\.el\\'" file-1)
                     (replace-match "-2.el" t nil file-1)))

Is that correct? So should the dir-locals-file-2 defconst and all its mentions be removed from doc? Or should that var instead be used in dir-locals--all-files and wherever else applicable?

--

Kaushal Modi