emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wait_reading_process_ouput hangs in certain cases (w/ patches)


From: Eli Zaretskii
Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches)
Date: Mon, 13 Nov 2017 05:27:43 +0200

> Cc: address@hidden
> From: Paul Eggert <address@hidden>
> Date: Sun, 12 Nov 2017 13:17:33 -0800
> 
> All that matters for got_some_output is whether it is negative, zero, or 
> positive. So I suggest replacing the above with the following, as it's a bit 
> faster and simpler and doesn't require commentary:
> 
> > +          if (wait_proc
> > +              && wait_proc->infd_num_bytes_read != 
> > initial_wait_proc_num_bytes_read)
> > +            got_some_output = 1;
> 
> Similarly for the other change that assigns to got_some_output.

You can read up-thread why I'm firmly against doing that.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]