Re: Something weird with when-let*/if-let*

[Noam Postavsky]

On Sat, Oct 14, 2017 at 9:47 AM, Noam Postavsky
<address@hidden> wrote:
> On Sat, Oct 14, 2017 at 9:12 AM, Eric Abrahamsen
> <address@hidden> wrote:
>
>>> The problem is simply that if-let* and when-let* don't exist in emacs 25.
>>
>> That was probably the case there, but that wouldn't explain Julien's
>> report, he's on master. And removing the star fixed it for him.
>
> It could be that subr-x wasn't loaded, which would also have the
> effect of if-let* and when-let* not existing. Although that wouldn't
> directly explain the non-star version working, perhaps when removing
> the star, subr-x got loaded? Seems especially likel

Oops, hit send too early. I meant to say that it could easily happen
in an interactive session, e.g., due to help-fns loading
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28607).

> nnimap.el doesn't explicitly require subr-x. It used to be required in
> message.el, until read-multiple-choice was moved to a separate file[1:
> 295457ae52], now it requires subr-x at compile time [2: 2d58d51329],
> but perhaps it doesn't work for nnimap.el depending on the order of
> compilation?
>
> [1: 295457ae52]: 2017-10-06 10:42:06 -0400
>   Move read-multiple-choice to its own library
>   
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=295457ae52eda341967821ebc5c053db1789b7c9
>
> [2: 2d58d51329]: 2017-10-06 20:49:39 +0300
>   Avoid byte-compilation warnings in message.el
>   
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2d58d513290f08819699e933bb0fbe88362c2131