[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-
From: |
Eric Abrahamsen |
Subject: |
Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook |
Date: |
Sun, 17 Sep 2017 14:37:35 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>> +(defcustom ebdb-install-save-hook t
>> + "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'."
>> + :group 'ebdb-eieio
>> + :type 'boolean)
>
> I think the docstring should talk about the intended effect from the
> user's point of view, rather than from the implementation's point
> of view. I'm not 100% sure what is the intended effect, but it seems to
> be something like "automatically save EBDB when leaving Emacs".
Yes, that's the intended effect. I'd originally had the `add-hook' at
top level in ebdb-com.el, so loading the file added the hook. That led
to `ebdb-save' being called when batch compiling and testing (ugh). I'll
re-work the docstring.
Thanks,
Eric