[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)
From: |
Andreas Schwab |
Subject: |
Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843) |
Date: |
Wed, 26 Jul 2017 20:54:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
On Jul 26 2017, Dmitry Gutov <address@hidden> wrote:
>> +(defconst grep--regexp-alist-bin-matcher
>> + '("^Binary file \\(.+\\) matches$" 1 nil nil 0 1))
>> +(defconst grep-with-null-regexp-alist
>> + `(("^\\([^\0]+\\)\\(\0\\)\\([0-9]+\\):" 1 3 ,grep--regexp-alist-column
>> nil nil
>
> Any reason to change 2 to 3? Why don't we use a non-capturing group for \0
> here?
Why using a group at all?
Andreas.
--
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."