[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (displa
From: |
Eli Zaretskii |
Subject: |
Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it. |
Date: |
Mon, 24 Jul 2017 20:01:14 +0300 |
> From: Glenn Morris <address@hidden>
> Date: Mon, 24 Jul 2017 12:57:41 -0400
> Cc: Stefan Monnier <address@hidden>, address@hidden
>
> --- i/lisp/display-line-numbers.el
> +++ w/lisp/display-line-numbers.el
> @@ -38,7 +38,6 @@ display-line-numbers
> "Display line numbers in the buffer."
> :group 'display)
>
> -;;;###autoload
> (defcustom display-line-numbers-type t
> "The default type of line numbers to use in `display-line-numbers-mode'.
> See `display-line-numbers' for value options."
> diff --git i/lisp/menu-bar.el w/lisp/menu-bar.el
> index 05a336b..e02217f 100644
> --- i/lisp/menu-bar.el
> +++ w/lisp/menu-bar.el
> @@ -1101,6 +1101,9 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom
> :button (:radio . (eq tool-bar-mode nil))))
> menu)))
>
> +;; Following function calls will autoload the library.
> +(defvar display-line-numbers-type)
> +
> (defun menu-bar-display-line-numbers-mode (type)
> (setq display-line-numbers-type type)
> (if global-display-line-numbers-mode
How is this better than the autoload? At least the autoload doesn't
need a comment to explain why it is there.
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Stefan Monnier, 2017/07/23
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Michael Albinus, 2017/07/23
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Glenn Morris, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it.,
Eli Zaretskii <=
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Stefan Monnier, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Eli Zaretskii, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Stefan Monnier, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Eli Zaretskii, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Stefan Monnier, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Stefan Monnier, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Eli Zaretskii, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Stefan Monnier, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Eli Zaretskii, 2017/07/24
- Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it., Stefan Monnier, 2017/07/24