[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/13] Nextstep: Use instancetype explicit return type
From: |
Paul Eggert |
Subject: |
Re: [PATCH 01/13] Nextstep: Use instancetype explicit return type |
Date: |
Sun, 21 May 2017 19:36:05 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 |
Oops, I spoke too quickly. This patch breaks the build on Ubuntu 16.04.2 LTS
x86-64, with the following being the first symptom:
In file included from nsterm.m:48:0:
nsterm.h: At top level:
nsterm.h:447:4: error: unknown type name ‘instancetype’
- (instancetype)menuDown: (id)sender;
^
Is that something you can fix? We need the Nextstep port to work with GNUstep as
well as with macOS.
Looking backward, I see that even before the recent patches the build was
already broken on Ubuntu 16.04.2 LTS, as follows:
nsfns.m: In function ‘Fns_set_mouse_absolute_pixel_position’:
nsfns.m:3101:3: error: unknown type name ‘CGPoint’
CGPoint mouse_pos = CGPointMake(mouse_x, mouse_y);
^
Still, we shouldn't make things worse. I'll CC: this to Alan Third and Anders
Lindgren to see whether they can advise.
- [PATCH 08/13] Nextstep: remove some deprecated method calls, (continued)
- [PATCH 08/13] Nextstep: remove some deprecated method calls, Philipp Stephani, 2017/05/20
- [PATCH 06/13] Remove calls to deprecated setUsesScreenFonts, Philipp Stephani, 2017/05/20
- [PATCH 10/13] Remove unused automatic variables, Philipp Stephani, 2017/05/20
- [PATCH 11/13] Clean up code around 'ns-list-services', Philipp Stephani, 2017/05/20
- [PATCH 12/13] Fix call of registerServicesMenuSendTypes, Philipp Stephani, 2017/05/20
- [PATCH 13/13] Avoid uninitialized read, Philipp Stephani, 2017/05/20
- Re: [PATCH 01/13] Nextstep: Use instancetype explicit return type, Paul Eggert, 2017/05/20
- Re: [PATCH 01/13] Nextstep: Use instancetype explicit return type,
Paul Eggert <=