|
From: | Paul Eggert |
Subject: | Re: [PATCH] Reimplement module functions |
Date: | Sat, 20 May 2017 13:46:20 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 |
A couple of minor things I noticed in the recently-installed patch:
const short minargs = function->min_arity;
In theory at least the arity might be greater than 32767, so this should be ptrdiff_t. Also, we typically don't use 'const' on locals, as it's not worth the screen real estate -- it should be easy even for a human reader to tell whether a local is assigned to later. (Likewise for 'register'.)
While looking into arity range I noticed a couple of other glitches in the neighborhood, and so installed the attached.
0001-Minor-fixes-for-arity-ranges-in-emacs-modules.txt
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |