Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification

[Eli Zaretskii]

> From: Johan Bockgård <address@hidden>
> Cc: address@hidden,  address@hidden,  address@hidden,  address@hidden
> Date: Sat, 06 May 2017 21:55:52 +0200
> 
> Eli Zaretskii <address@hidden> writes:
> 
> >> From: Johan Bockgård <address@hidden>
> >> Cc: Eli Zaretskii <address@hidden>, address@hidden,
> >> address@hidden, address@hidden
> >> Date: Sat, 06 May 2017 19:51:33 +0200
> >> 
> >> > +  (if (string-match (concat "\\`" (or  regexp "[ \t\n\r]+")) string)
> >> 
> >> I think regexp should be surrounded by a grouping construct, like:
> >> 
> >>    (concat "\\`\\(?:" (or  regexp "[ \t\n\r]+") "\\)")
> >> 
> >> And similarly for string-trim-right.
> >
> > Rationale?
> 
> regexp can contain \|

Shouldn't such a regexp be surrounded by "\\(..\\)"?