|
| From: | Stefan Monnier |
| Subject: | Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) |
| Date: | Wed, 19 Apr 2017 08:12:15 -0400 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
>> The ugliness is that the kill-this-buffer code uses
>> menu-bar-non-minibuffer-window-p and
>> menu-bar-menu-frame-live-and-visible-p both of which consult
>> menu-updating-frame because they are designed to be used in menu
>> attributes (as in :enable, :active, ...).
> There's no ugliness: this function was designed to be used from a menu
> bar.
menu-bar-non-minibuffer-window-p is for use in menu-bar item
attributes that are evaluated while building the menu-bar itself.
It shouldn't be used in commands, even those that are bound to menu-bar
events.
Stefan
| [Prev in Thread] | Current Thread | [Next in Thread] |