emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master a855473 2/2: Use user-error for customize's "invalid face" er


From: Stefan Monnier
Subject: Re: master a855473 2/2: Use user-error for customize's "invalid face" error
Date: Fri, 14 Apr 2017 10:11:38 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

> After committing the following I noticed that you left it out of your
> 71873e2.  Do you remember why?

Probably some oversight or manipulation error.
At least I can't remember deciding consciously that this would be undesirable,
and can't see any reason why I'd have decided such a thing either.


        Stefan


>> branch: master
>> commit a855473b7079b467ac01dbcee89cb57b3599fdac
>> 
>> Use user-error for customize's "invalid face" error
>> 
>> * lisp/cus-edit.el (customize-face): Use user-error.
>> (debug-ignored-errors): No more need to add "Invalid face".
>> ---
>> lisp/cus-edit.el | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>> 
>> diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
>> index f408e83..ca6b8a3 100644
>> --- a/lisp/cus-edit.el
>> +++ b/lisp/cus-edit.el
>> @@ -1334,7 +1334,7 @@ suggest to customize that face, if it's customizable."
>> (if (get face 'face-alias)
>> (setq face (get face 'face-alias)))
>> (unless (facep face)
>> -    (error "Invalid face %S" face))
>> +    (user-error "Invalid face %S" face))
>> (funcall display-fun
>> (list (list face 'custom-face))
>> (format "*Customize Face: %s*"
>> @@ -4846,8 +4846,6 @@ if that value is non-nil."
>> 
>> (define-obsolete-function-alias 'custom-mode 'Custom-mode "23.1")
>> 
>> -(add-to-list 'debug-ignored-errors "^Invalid face:? ")
>> -
>> ;;; The End.
>> 
>> (provide 'cus-edit)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]