emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/record 25aa500 5/5: Backward compatibility wit


From: Stefan Monnier
Subject: Re: [Emacs-diffs] scratch/record 25aa500 5/5: Backward compatibility with pre-existing struct instances.
Date: Wed, 29 Mar 2017 08:26:10 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

> There's also a lingering FIXME that you added:
>
>  (cl-defstruct (eieio--object
> -               (:type vector)           ;We manage our own tagging system.
> +               (:type vector) ;; FIXME!  ;We manage our own tagging system.
>                 (:constructor nil)
>
> As far as I can see, the struct isn't used directly.

Indeed, which is why it works despite the inconsistency.

> These definitions are derived from it: eieio--object-class-tag, and
> eieio--object-num-slot.  The first just aref slot 0, and the second is 1.

That's right.  I put a FIXME because this inconsistency is ugly.
I'm not completely sure how best to fix it, tho.  Maybe just define
those two accessors by hand.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]