[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] Run occur command restricted to a region
From: |
Juri Linkov |
Subject: |
Re: [patch] Run occur command restricted to a region |
Date: |
Mon, 30 Jan 2017 02:09:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) |
>>> +Optional arg REGION, if non-nil, mean restrict search to the
>>> +specified region. Otherwise search the entire buffer.
>>> +When REGION is non-nil, it must be a cons (START . END).
>>
>> When someone decides to add support for rectangular regions in occur later,
>> your current implementation will make this problematic since it changes
>> the format ((START . END)) to (START . END), that makes difficult to support
>> ((START1 . END1) (START2 . END2) ...) later.
>>
>> Let's stick to the same format in all uses of the new ‘REGION’ arg, and
>> currently in occur support only the degenerate case of ((START . END))
>> for non-rectangular regions.
>
> Thanks. I was also a bit worry with that detail.
> OK, i keep the general format ((START . END)).
> Let me know if the following patch is OK to be pushed:
Looks good to me, but you have to ask Eli for the permission to push.
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/03
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/18
- Re: [patch] Run occur command restricted to a region, Juri Linkov, 2017/01/19
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/20
- Re: [patch] Run occur command restricted to a region, Davis Herring, 2017/01/20
- Re: [patch] Run occur command restricted to a region, Juri Linkov, 2017/01/20
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/22
- Re: [patch] Run occur command restricted to a region, Juri Linkov, 2017/01/22
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/23
- Message not available
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/29
- Re: [patch] Run occur command restricted to a region,
Juri Linkov <=
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/29
- Re: [patch] Run occur command restricted to a region, Tino Calancha, 2017/01/29
- Re: [patch] Run occur command restricted to a region, Eli Zaretskii, 2017/01/30