emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (b


From: Leo Liu
Subject: Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)
Date: Wed, 28 Dec 2016 09:38:12 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (macOS 10.12.2)

On 2016-12-27 17:44 +0000, Stefan Monnier wrote:
> branch: master
> commit e6161f648903d821865b9610b3b6aa0f82a5dcb7
> Author: Stefan Monnier <address@hidden>
> Commit: Stefan Monnier <address@hidden>
>
>     * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)
>     
>     (inline--dont-quote): Quote the function with #' when passing it to 
> `apply'.
> ---
>  lisp/emacs-lisp/inline.el |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el
> index 058c56c..5ceb0d9 100644
> --- a/lisp/emacs-lisp/inline.el
> +++ b/lisp/emacs-lisp/inline.el
> @@ -191,9 +191,9 @@ After VARS is handled, BODY is evaluated in the new 
> environment."
>         (while (and (consp exp) (not (eq '\, (car exp))))
>           (push (inline--dont-quote (pop exp)) args))
>         (setq args (nreverse args))
> -       (if exp
> -           `(apply ,@args ,(inline--dont-quote exp))
> -         args)))
> +       (if (null exp)
> +           args
> +         `(apply #',(car args) ,@(cdr args) ,(inline--dont-quote exp)))))
>      (_ exp)))
>  
>  (defun inline--do-leteval (var-exp &rest body)
>

Could we have this bug fixed in emacs-25? inline.el is new in 25.1 and
broken. We should make sure 25.x have a usable version. Thoughts?

Leo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]