emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] assq-delete-all, rassq-delete-all: Avoid duplication of code


From: Herring, Davis
Subject: RE: [PATCH] assq-delete-all, rassq-delete-all: Avoid duplication of code
Date: Mon, 28 Nov 2016 13:58:55 +0000

> +(defun assq-delete-all-1 (elt alist key)
> +  (let ((op (if key #'car #'cdr)))

I would just pass `op' instead.  It makes the callers clearer, and also avoids 
the confusion of "use the key, not the value?" vs. "this is the key" for the 
variable `key'.

Davis



reply via email to

[Prev in Thread] Current Thread [Next in Thread]