emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names hav


From: Mark Oteiza
Subject: Re: [Emacs-diffs] master 16e705b: Make sure elided long buffer names have ellipses added (Bug#24972)
Date: Wed, 23 Nov 2016 12:01:50 -0500
User-agent: Mutt/1.7.1+41 (5382e1e4cee1) (2016-10-04)

On 22/11/16 at 08:17am, Stefan Monnier wrote:
> > -           `(truncate-string-to-width
> > -             ,strvar strlen nil nil
> > -             ,ellipsis))
> > +           `(concat
> > +             (truncate-string-to-width
> > +                   ,strvar (- strlen (string-width ,ellipsis)) nil ?.)
> > +                  ,ellipsis))
> 
> Hmm... why was this needed?
> 
> 
>         Stefan "maybe it should be fixed in truncate-string-to-width instead"

Your guess would probably be better than mine.  Perhaps I needed to
/add/ the length of the ellipsis to strlen in the removed code?  I was
quite ready to rip my hair out trying to make sense of all that ibuffer
machinery.  Horribly untestable the way it's written as well.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]