|
| From: | Stefan Monnier |
| Subject: | Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions |
| Date: | Sun, 23 Oct 2016 16:31:24 -0400 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) |
> + /* Update 'base' due to possible relocation inside re_search_2. */
> + base = current_buffer->text->beg;
I recommend wrapping this in "#if REL_ALLOC", so as to make it clear why
relation might be possible (e.g. to distinguish from GC-triggered
relocation, for example) and to make it clear what could be gained by
getting rid of REL_ALLOC.
Stefan
| [Prev in Thread] | Current Thread | [Next in Thread] |