[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New command to invert lines in region
|
From: |
Noam Postavsky |
|
Subject: |
Re: [PATCH] New command to invert lines in region |
|
Date: |
Sun, 16 Oct 2016 09:24:25 -0400 |
On Sat, Oct 15, 2016 at 6:25 PM, Mathias Dahl <address@hidden> wrote:
>
> Out of curiosity I had a look at the current implementation of
> `reverse-region' and found it quite complicated and hard to understand what
> it does. I wrote my own naïve version that I think is much simpler to
> understand
It looks to me that your version is simpler mainly because you dropped
the handling of some corner cases. Having some tests to check those
would be required before replacing the implementation. Using
split-string does seem like a good idea though (probably that function
didn't exist yet when reverse-region was written).