emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove unused variable `command-debug-status'


From: Kaushal Modi
Subject: Re: [PATCH] Remove unused variable `command-debug-status'
Date: Wed, 28 Sep 2016 14:30:47 +0000

On Wed, Sep 28, 2016 at 7:25 AM Philippe Vaucher <address@hidden> wrote:
Well, I had to do copyright assignements for ztree, but that was on github (https://github.com/fourier/ztree/pull/33).

If the copyright assignment was to FSF, then someone having a fencepost account can confirm if you are on the list. I cannot.

Oh, I did that in the past but I thought that was meant for general bug reporting.

Based on some recent discussions, the bug report email is meant for everything: bug reports, feature requests, patch submissions, etc
 
Do messages sent to address@hidden also end on emacs-devel?

No. Those end up on the bug-gnu-emacs mailing list. I believe almost all core developers subscribe to that. Normally, when I submit a patch, I CC one or two people whose code I am modifying. (The new vc-region-history command in emacs 25.1 is really useful for that.) If you do not get a feedback in about a week or so, it might be useful copying emacs-devel mailing list and referring them to the bug thread to see if anyone can review and commit it for you.
 
For information, messages like https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00635.html don't seem to follow this "patches as bug reports" philosophy.

Yeah, the patch submitter needs to ping emacs-devel if they don't get any response to their update.
 
Anyway, I found on https://www.kernel.org/doc/Documentation/email-clients.txt that GMail's UI is not good to send inline patches, so I'll send them to address@hidden as attachment instead (that or setup another client).

I have always sent patches via Google Inbox. They ended up fine. The only instance where I had to send a patch as an attachment was when it contained both tab and space characters (I was trying to not mess up the original whitespace). In such cases, you need to send the patch as an attachment. Nowadays, with recent commits you will rarely find the tab chars in the patch diffs (which is a good thing!). So inline patches work just fine.

For reading sanity, I always send emails via Gmail/Inbox without any rich text formatting.
--

Kaushal Modi


reply via email to

[Prev in Thread] Current Thread [Next in Thread]