emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master ca47390: image-dired: Report when a necessary executable is n


From: Clément Pit--Claudel
Subject: Re: master ca47390: image-dired: Report when a necessary executable is not found
Date: Mon, 5 Sep 2016 11:48:15 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 2016-09-05 01:30, Tino Calancha wrote:
> Good point.  I agree is a nuisance having to set those values
> after installing the executable.
> How about following more simple patch?:
> It just check for the required executable at the top of each function
> using it; it signals an error if the executable is not found:

Looks good, but maybe you could extract this to a separate function that takes 
the variable name and produces the error?  There's a bit of duplication in the 
patch you posted.

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]