emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Small docstring improvements


From: John Wiegley
Subject: Re: Small docstring improvements
Date: Fri, 19 Aug 2016 14:12:50 -0700
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1 (darwin)

>>>>> "PS" == Philipp Stephani <address@hidden> writes:

PS> I've simply copied the docstring from write-region, which has exactly the
PS> same semantics (because call-process-region calls write-region). Like it
PS> or not, these are the semantics, and they are intentional (the code for
PS> call-process-region has explicit branches for these cases), so I think
PS> they deserve to be documented.

Yes, agreed with respect to your patch, disagree only with respect to what you
found there. :) Those explicit branches shouldn't have been written. It sounds
like its purely an attempt to avoid creating new functions for what is clearly
new functionality.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]