[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Latest master broken on Cocoa/NS
From: |
Clément Pit--Claudel |
Subject: |
Re: Latest master broken on Cocoa/NS |
Date: |
Fri, 15 Jul 2016 15:51:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 2016-07-15 15:35, Stefan Monnier wrote:
>>> Before trying it, can you please offer some motivation for why we want this
>>> change? That would help us in reading it.
>> For NS, this is a no-op.
>> For others, this addresses the cases where tooltips are 'first-class'
>> frames in Emacs terms (--with-x-toolkit={no,lucid,motif}, MS Windows,
>> GTK[23] builds when 'x-gtk-use-system-tooltips' is nil). The goal was
>> to avoid tricky global variables and (hopefully) to reduce overall
>> complexity of the relevant code.
>
> I'm completely unfamiliar with this code so can't say anything
> intelligent about that change (and don't have any opinion whether it's
> good or not).
>
> But it does ring a bell here: for company-mode's popup menus, we'd want
> to be able to create non-toolkit popup frames, even if Emacs was built
> with support for toolkit popup frames.
I can't say anything about the patch either, but something confuses me a bit:
why does displaying non-toolkit popups require so much C code? If we just
extracted the ability to create chrome-less frames from that code, couldn't all
the rest be written in Lisp?
I tried to do this and got things semi-working with Eli's help, but then got
confused about what had to be done for it to work on Windows as well.
Clément.
signature.asc
Description: OpenPGP digital signature
- Re: Latest master broken on Cocoa/NS, (continued)
- Re: Latest master broken on Cocoa/NS, John Wiegley, 2016/07/12
- Re: Latest master broken on Cocoa/NS, Dmitry Antipov, 2016/07/14
- Re: Latest master broken on Cocoa/NS, John Wiegley, 2016/07/14
- Re: Latest master broken on Cocoa/NS, Dmitry Antipov, 2016/07/15
- Re: Latest master broken on Cocoa/NS, John Wiegley, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Eli Zaretskii, 2016/07/15
- Re: Latest master broken on Cocoa/NS, martin rudalics, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Eli Zaretskii, 2016/07/15
- Re: Latest master broken on Cocoa/NS, martin rudalics, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Stefan Monnier, 2016/07/15
- Re: Latest master broken on Cocoa/NS,
Clément Pit--Claudel <=
- Re: Latest master broken on Cocoa/NS, Eli Zaretskii, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Clément Pit--Claudel, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Eli Zaretskii, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Clément Pit--Claudel, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Eli Zaretskii, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Clément Pit--Claudel, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Eli Zaretskii, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Dmitry Gutov, 2016/07/15
- Re: Latest master broken on Cocoa/NS, martin rudalics, 2016/07/15
- Re: Latest master broken on Cocoa/NS, Clément Pit--Claudel, 2016/07/15