emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ampc back on elpa?


From: Cédric Chépied
Subject: Re: ampc back on elpa?
Date: Fri, 17 Jun 2016 18:43:23 +0200
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/25.1.50 (x86_64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)

On Wed, 15 Jun 2016 15:35:43 +0200,
Stefan Monnier wrote:
> Looks good.  I was about to install the change into elpa.git but I can't
> find your name in the list of people who assigned copyright.
> Have you signed the copyright paperwork?

Signed but not sent. I'm too lazy, post office is so far...
I'm sending it tomorrow.

> In the mean time, here's a comment about:
> 
> +(defun ampc-start-search ()
> +  "Ask mpd to search for songs matching keywords"
> +  (interactive)
> +  (cl-assert (ampc-in-ampc-p))
> +  (let ((search (read-string "Keywords: ")))
> 
> This should look more like
> 
>     (defun ampc-start-search (search)
>       "Ask mpd to search for songs matching keywords."
>       (interactive "sKeywords: ")
>       (cl-assert (ampc-in-ampc-p))

I'm sending a new patch soon for this. 

Thanks for the help.
-- 
Cédric Chépied
<address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]