|
| From: | Andreas Röhler |
| Subject: | Re: Code reviews |
| Date: | Thu, 10 Mar 2016 11:16:11 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
Here just my two cents:WRT logs: code itself as basic reference, i.e. using rather the diffs than second sources like log-messages. In favor of dropping the changelog.
WRT code-review: More important seems a rigid test-policy, i.e. no commit without tests passed. Focus on analyze why things got broken, how the bug could pass the tests.
Cheers, Andreas
| [Prev in Thread] | Current Thread | [Next in Thread] |