[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: master 71783e9: Add the string-numeric-lessp function
From: |
Drew Adams |
Subject: |
RE: master 71783e9: Add the string-numeric-lessp function |
Date: |
Sun, 6 Mar 2016 18:27:50 -0800 (PST) |
`string-numeric-lessp' really should follow the Emacs
convention and be called `string-numeric-less-p'.
It's not because `string-less-p' is misnamed that we
should add to this mistake. `time-less-p' is correctly
named, for example.
Or else the rule should be clarified to incorporate
`-lessp' exceptions, so they are within, and not outside,
the rule.
The following 25 are the only such misnamed predicates
I see (in a pretty minimal setup - there may be some
more in Gnus, Org, etc.). 6 of them end in `-lessp'.
auth-source-specmatchp
bool-vector-subsetp
byte-compile-nilconstp
byte-compile-trueconstp
byte-optimize-all-constp
byte-optimize-zerop
cl--compiler-macro-typep
cl--macroexp-fboundp
coding-system-lessp
custom-facep
customize-version-lessp
default-boundp
dired-tree-lessp
eieio--typep
file-attributes-lessp
gnus-boundp
gnutls-error-fatalp
gnutls-errorp
hack-one-local-variable-constantp
hack-one-local-variable-eval-safep
hack-one-local-variable-quotep
ls-lisp-string-lessp
slot-boundp
string-lessp
uniquify-item-greaterp
That's 25 out of 438 predicates total whose names end in
`p', which I count at the outset in a pretty minimal setup.
So less than 6% of predicate names that end in `p' do not
follow the rule. 94% follow it correctly.
The following predicates are also wrongly named, but they
should not have prefix `cl-' anyway. Remove the misguided
prefix and these names will all follow the rule.
cl-endp
cl-equalp
cl-evenp
cl-minusp
cl-oddp
cl-plusp
cl-subsetp
cl-tailp
cl-typep
RE: master 71783e9: Add the string-numeric-lessp function,
Drew Adams <=