[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Use of strftime in movemail.ec
From: |
Eli Zaretskii |
Subject: |
Re: Use of strftime in movemail.ec |
Date: |
Sun, 06 Mar 2016 18:28:52 +0200 |
> Cc: address@hidden
> From: Paul Eggert <address@hidden>
> Date: Sat, 5 Mar 2016 12:56:49 -0800
>
> Eli Zaretskii wrote:
> > How about the follow-up below?
>
> Yes, that's more general and shouldn't introduce bugs. It can mishandle %% in
> formats, if you care about full upward-compatibility. It should use memcpy
> instead of strncpy.
>
> Personally I'd leave the code alone for simplicity's sake, but if you prefer
> the
> more-general version by all means....
Thanks for the review and the comments. I fixed the patch as you
suggested and pushed it.