emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gmane.emacs.diffs] master 2621c29: Use colors in the VC mode lines


From: Mark Oteiza
Subject: [gmane.emacs.diffs] master 2621c29: Use colors in the VC mode lines
Date: Fri, 04 Mar 2016 22:06:38 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

This is a gripe:

Changing the faces like this is annoying for a few reasons:

- The mode line already shows most of these states with a
  character. This is documented.

- Whether or not people know what the characters mean, the faces have no
  further meaning over that of the characters, and are otherwise
  undocumented.

- The choice of colors is somewhat arbitrary, some of them are the same,
  and there is no inheritance other than to the base-face.

- Anyone who wants the faces to just be the same has to configure every
  single vc face except the base face

- Anyone who wants the faces to be different is going to override these
  faces anyways

- Every theme author likely has to account for every VC face instead of
  one (or none) because of the previous two points

Side point: Óscar already added a news item for the faces in
emacs-25. Now there is another NEWS item in master (the change
subsequent to the subject one).

--- Begin Message --- Subject: master 2621c29: Use colors in the VC mode lines Date: Tue, 01 Mar 2016 03:25:55 +0000 (3 days, 16 hours, 52 minutes ago)
branch: master
commit 2621c293d82c15c00d9e73a8db75d70da7d0a23b
Author: Lars Ingebrigtsen <address@hidden>
Commit: Lars Ingebrigtsen <address@hidden>

    Use colors in the VC mode lines
    
    * lisp/vc/vc-hooks.el: Make the mode line faces default to
    using colors to more clearly tell the user what the status is.
---
 lisp/vc/vc-hooks.el |   23 +++++++++++++++--------
 1 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el
index 0c1718e..6488e53 100644
--- a/lisp/vc/vc-hooks.el
+++ b/lisp/vc/vc-hooks.el
@@ -54,44 +54,51 @@
   :group 'vc-faces)
 
 (defface vc-needs-update-state
-  '((default :inherit vc-state-base-face))
+  '((default :inherit vc-state-base-face)
+    (((class color)) :foreground "blue" :weight bold))
   "Face for VC modeline state when the file needs update."
   :version "25.1"
   :group 'vc-faces)
 
 (defface vc-locked-state
-  '((default :inherit vc-state-base-face))
+  '((default :inherit vc-state-base-face)
+    (((class color)) :foreground "red"))
   "Face for VC modeline state when the file locked."
   :version "25.1"
   :group 'vc-faces)
 
 (defface vc-locally-added-state
-  '((default :inherit vc-state-base-face))
+  '((default :inherit vc-state-base-face)
+    (((class color)) :foreground "ForestGreen"))
   "Face for VC modeline state when the file is locally added."
   :version "25.1"
   :group 'vc-faces)
 
 (defface vc-conflict-state
-  '((default :inherit vc-state-base-face))
+  '((default :inherit vc-state-base-face)
+    (((class color)) :foreground "red" :weight bold))
   "Face for VC modeline state when the file contains merge conflicts."
   :version "25.1"
   :group 'vc-faces)
 
 (defface vc-removed-state
-  '((default :inherit vc-state-base-face))
+  '((default :inherit vc-state-base-face)
+    (((class color)) :foreground "red"))
   "Face for VC modeline state when the file was removed from the VC system."
   :version "25.1"
   :group 'vc-faces)
 
 (defface vc-missing-state
-  '((default :inherit vc-state-base-face))
+  '((default :inherit vc-state-base-face)
+    (((class color)) :foreground "red"))
   "Face for VC modeline state when the file is missing from the file system."
   :version "25.1"
   :group 'vc-faces)
 
 (defface vc-edited-state
-  '((default :inherit vc-state-base-face))
-  "Face for VC modeline state when the file is up to date."
+  '((default :inherit vc-state-base-face)
+    (((class color)) :foreground "ForestGreen"))
+  "Face for VC modeline state when the file is edited."
   :version "25.1"
   :group 'vc-faces)
 


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]