emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Recommend these .gitconfig settings for git integrity.


From: Karl Fogel
Subject: Re: Recommend these .gitconfig settings for git integrity.
Date: Mon, 01 Feb 2016 09:42:51 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux)

Quoting Paul Eggert <address@hidden> out of order:
>I installed the attached patch to try to automate this; I think
>this'll be more effective.

*nod*  That has autogen.sh install the setting in the repository-specific git 
config.  That's a good a companion to also including the advice in 
admin/notes/git-workflow and http://www.emacswiki.org/emacs/GitForEmacsDevs, 
but by itself it's not enough, I think.  It only takes effect after the user 
runs autogen.sh, so she might have pulled an arbitrary number of times before 
the setting gets put in place by autogen.sh.

>We shouldn't need to configure fetch.fsckObjects and
>receive.fsckObjects, as they default to transfer.fsckObjects.

Yeah... Hmmm.  I think Eric Myhre's post recommending all three setting was his 
too-simple-to-fail way of making sure that users didn't have a combination 
whereby transfer.fsckObjects=true was overridden by one or both of 
fetch.fsckObjects=false or receive.fsckObjects=false.

Anyway, we seem to have consensus that the intended resultant setting is a good 
one.  So I'll add the advice to the above file and wiki page, and will find 
some way to express the desired result without asking the user to make 
redundant settings.

Best regards,
-Karl

>>From b1ccd481738b1427ac0e294f2405a9ebe86c8561 Mon Sep 17 00:00:00 2001
>From: Paul Eggert <address@hidden>
>Date: Sun, 31 Jan 2016 13:43:13 -0800
>Subject: [PATCH] autogen.sh now arranges for git to check hashes
>
>Suggested by Karl Fogel in:
>http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01802.html
>* autogen.sh: Do "git config transfer.fsckObjects true".
>---
> autogen.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/autogen.sh b/autogen.sh
>index a63c53c..877bb84 100755
>--- a/autogen.sh
>+++ b/autogen.sh
>@@ -220,6 +220,11 @@ echo timestamp > src/stamp-h.in || exit
> ## Configure Git, if using Git.
> if test -d .git && (git status -s) >/dev/null 2>&1; then
> 
>+    # Check hashes when transferring objects among repositories.
>+
>+    git config transfer.fsckObjects true || exit
>+
>+
>     # Configure 'git diff' hunk header format.
> 
>     git config 'diff.elisp.xfuncname' \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]