emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: member inconsistency?


From: Eli Zaretskii
Subject: Re: member inconsistency?
Date: Thu, 28 Jan 2016 20:35:40 +0200

> From: Stephen Berman <address@hidden>
> Cc: address@hidden,  address@hidden,  address@hidden,  address@hidden
> Date: Thu, 28 Jan 2016 18:30:04 +0100
> 
> diff --git a/src/fns.c b/src/fns.c
> index 86ad333..17c4a75 100644
> --- a/src/fns.c
> +++ b/src/fns.c
> @@ -1349,7 +1349,7 @@ The value is actually the tail of LIST whose car is 
> ELT.  */)
>    (register Lisp_Object elt, Lisp_Object list)
>  {
>    register Lisp_Object tail;
> -  for (tail = list; CONSP (tail); tail = XCDR (tail))
> +  for (tail = list; CONSP (tail) || !NILP (tail); tail = XCDR (tail))
>      {
>        register Lisp_Object tem;
>        CHECK_LIST_CONS (tail, list);
> 
> Or is having the check before the loop better it catches the error sooner?

Before the loop sounds slightly less obscure to me.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]