emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 c71e1e8: Use short date for 'hg annotate', a


From: Ken Brown
Subject: Re: [Emacs-diffs] emacs-25 c71e1e8: Use short date for 'hg annotate', and output the author
Date: Mon, 11 Jan 2016 14:58:11 -0500
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 1/10/2016 12:40 PM, Ken Brown wrote:
On 1/9/2016 8:13 PM, Dmitry Gutov wrote:
+(ert-deftest vc-hg-annotate-extract-revision-at-line-with-filename ()
+  ;; with filename
+  (with-temp-buffer
+    (save-excursion (insert "215 2007-06-20 CONTENTS:"))
+    (should (equal (vc-hg-annotate-extract-revision-at-line)
+                   (cons
+                    "215"
+                    (expand-file-name "test/automated/CONTENTS"
+                                      source-directory))))))
+

[...]

+(ert-deftest vc-hg-annotate-extract-revision-at-line-with-both ()
+  (with-temp-buffer
+    (save-excursion (insert "philringnalda 218075 2014-11-28 CLOBBER:"))
+    (should (equal (vc-hg-annotate-extract-revision-at-line)
+                   (cons
+                    "218075"
+                    (expand-file-name "test/automated/CLOBBER"
+                                      source-directory))))))

These two tests fail on an out-of-tree build.

How about the following fix:

diff --git a/test/automated/vc-hg.el b/test/automated/vc-hg.el
index 6828271..76ba785 100644
--- a/test/automated/vc-hg.el
+++ b/test/automated/vc-hg.el
@@ -34,8 +34,8 @@
     (should (equal (vc-hg-annotate-extract-revision-at-line)
                    (cons
                     "215"
-                    (expand-file-name "test/automated/CONTENTS"
-                                      source-directory))))))
+                    (expand-file-name "CONTENTS"
+                                      default-directory))))))

 (ert-deftest vc-hg-annotate-extract-revision-at-line-with-user ()
   (with-temp-buffer
@@ -49,8 +49,8 @@
     (should (equal (vc-hg-annotate-extract-revision-at-line)
                    (cons
                     "218075"
-                    (expand-file-name "test/automated/CLOBBER"
-                                      source-directory))))))
+                    (expand-file-name "CLOBBER"
+                                      default-directory))))))

 (ert-deftest vc-hg-annotate-time ()
   (with-temp-buffer

Ken



reply via email to

[Prev in Thread] Current Thread [Next in Thread]