Re: [PATCH] Override Windows default Win-* key combinations when using Emacs

[Jussi Lahdenniemi]

> Thank you for your contribution.  It is large enough to require legal
> paperwork; I can send you the forms off-list if you agree.

Sure!

> As for the patch: why does this have to be an external program?  Can't
> Emacs itself do this job?  Doing part of Emacs's keyboard input in a
> separate process has several downsides, so I think it should be
> avoided if possible.

While submitting the change, I thought about this as well. I wrote the 
code four years ago, and could not remember why I chose this approach; 
possibly both for better performance when several emacses are running 
and for smaller changes in the core emacs code (as that was the first 
time I touched the emacs code base).

I'll see how much it would take to incorporate the code in the emacs 
process.

> Also, did you try this with the latest Emacs sources?  The way
> keyboard input works in Emacs on Windows has changed several months
> ago.

Yes, this patch was done on the latest emacs master branch on git. Also, 
I verified that the w32-register-hot-key does not do the job for the 
Windows key combinations.

> Finally, will this also work in the console (a.k.a. "TTY") session, or
> just in GUI sessions?

No, it currently only works for GUI. Supporting the console would 
require some additional code (to check if the currently active window is 
a console running Emacs, basically) but it could be done. I'll check 
this as well.

--
Jussi Lahdenniemi