Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads.

[Eli Zaretskii]

> From: Philipp Stephani <address@hidden>
> Date: Wed, 23 Dec 2015 16:01:30 +0000
> 
> OK, here's a patch. 

Thanks.  A few minor comments.

> +AC_ARG_ENABLE(deterministic-dump,
> +[AS_HELP_STRING([--enable-deterministic-dump],
> +                [Make dumping deterministic by removing system-specific
> +                information from the dump, such as host names and
> +                timestamps.])])

I'd prefer calling this "deterministic-build", so that we could use it
to solve any other similar problems unrelated to dumping.  Maybe even
"reproducible-build".

(If we do change the option, we should also change the name of the
variable and the cpp symbol.)

> +(defconst emacs-build-system
> +  (if deterministic-dump "unknown" (system-name))
>    "Name of the system on which Emacs was built.")

Can we find a better string, like "elided" or "undisclosed"?
"Unknown" sounds too self-derogatory.

> +  DEFVAR_BOOL ("deterministic-dump", Vdeterministic_dump,
> +    doc: /* If t, attempt to make dumping deterministic by avoiding

I think the usual style is "If non-nil".

> +sources of nondeterminism such as absolute paths, the hostname, or

GNU coding standards frown on using "path" for anything that isn't
PATH-style list of directories.  Please use "file name" instead.