[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adding to ELPA?
From: |
David Kastrup |
Subject: |
Re: Adding to ELPA? |
Date: |
Sat, 10 Oct 2015 09:50:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Artur Malabarba <address@hidden> writes:
> On 9 Oct 2015 4:28 pm, "David Kastrup" <address@hidden> wrote:
>>
>>
>> Unfortunately, the list server seems to be really, really, slow right
>> now. At any rate, would it be the correct way of proceeding to just
>> push the following commit to ELPA? Just like that?
>
> If you've done it before, then yes, pretty much.
> If you haven't, showing the patch here (like you just did) is a good idea
> to make sure you're doing it right.
>
> You can also bring it here if you're unsure whether it's GElpa material
> (whatever that means). Maybe we should request that people always mention
> it here before uploading new packages, just to make sure it's not
> replicating an existing one.
>
> As for your code, I noticed two things.
> 1. See other packages for the copyright line used.
Ah yes, of course. It would need to be assigned.
> 2. You need to depend on cl-lib 0.5 and require it (probably at compile
> time).
Why? It's autoloaded. The problem is more that I am fuzzy on what
Emacs versions to require here if any. Until rather recently, Emacs
tended to lose events placed into unread-command-events when they were
arriving not one-by-one. With many MIDI input applications (but not
necessarily all) that's going to end up a problem.
If I require a sufficiently new Emacs version (I don't think any
released version suffices), the cl-lib dependency should be a non-issue.
--
David Kastrup
- Adding to ELPA?, David Kastrup, 2015/10/09
- Re: Adding to ELPA?, Artur Malabarba, 2015/10/10
- Re: Adding to ELPA?,
David Kastrup <=
- Re: Adding to ELPA?, Artur Malabarba, 2015/10/11
- Re: Adding to ELPA?, David Kastrup, 2015/10/15
- Re: Adding to ELPA?, Artur Malabarba, 2015/10/11
- Re: Adding to ELPA?, David Kastrup, 2015/10/11
- Re: Adding to ELPA?, Artur Malabarba, 2015/10/11
- Re: Adding to ELPA?, David Kastrup, 2015/10/15
- Re: Adding to ELPA?, Artur Malabarba, 2015/10/12