Re: [Emacs-diffs] master da4ce83: * nt/INSTALL: Update instructions for running autogen.sh

[Stefan Monnier]

>   if test -d .git; then
>
>      # Configure 'git diff' hunk header format.
>
>      git config 'diff.elisp.xfuncname' \
>        '^\(def[^[:space:]]+[[:space:]]+([^()[:space:]]+)' || exit
>      git config 'diff.texinfo.xfuncname' \                  ^^^^^^^
>        'address@hidden:space:]]+([^,[:space:]][^,]+)' || exit
>                                                 ^^^^^^^
>
> It exits with an error message, which in my book means it "fails".

Hmm... I see.
So the "test -d .git" ensures that this code is only run when Git was
used to get the code, so we can reasonably assume that Git is (still)
available.  I understand your text better now, thanks.

Still, I think the above code is making a poor choice.  Better emit the
warning and keep on going: these "git config" settings are sufficiently
important to justify aborting the whole operation, IMO.


        Stefan