[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patches on ffap (mainly for latex buffers)
From: |
Stefan Monnier |
Subject: |
Re: Patches on ffap (mainly for latex buffers) |
Date: |
Fri, 07 Aug 2015 11:47:32 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> * lisp/ffap.el (ffap-string-at-point-mode-alist): Remove useless and
> misleading backslashes from default value.
[...]
> - (file "--:\\\\$\\{\\}+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
> + (file "--:\\\\${}+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
^^
This one as well, AFAIK.
> Subject: [PATCH 3/4] * lisp/ffap.el (ffap-latex-mode): Use kpsewhich if
> available
Looks OK to me.
> + (prefixes '(""
> + "beamertheme"
> + "beamercolortheme"
> + "beamerfonttheme"
> + "beamerinnertheme"
> + "beameroutertheme"))
These prefixes look rather ad-hoc. Do we really need them? Why?
> + ;; is found before point on the current line. It should cover
> most
^^^
Please put 2 spaces between sentences.
Also some of your lines are more than 80 columns wide. Please try and
avoid that.
> The fourth (and last) patch fixes a problem introduced in commit
> ba6c32b6decaa2a72a3d5f854efd513e8e82c118, where braces were allowed in
> filenames. This is not good for TeX and friends, where braces are
> delimiters, as in \input{foo}.
Looks fine to me, thanks,
Stefan
- Patches on ffap (mainly for latex buffers), Nicolas Richard, 2015/08/06
- Re: Patches on ffap (mainly for latex buffers),
Stefan Monnier <=
- Re: Patches on ffap (mainly for latex buffers), Nicolas Richard, 2015/08/07
- Re: Patches on ffap (mainly for latex buffers), Stefan Monnier, 2015/08/07
- Re: Patches on ffap (mainly for latex buffers), Nicolas Richard, 2015/08/08
- Re: Patches on ffap (mainly for latex buffers), Nicolas Richard, 2015/08/09
- Re: Patches on ffap (mainly for latex buffers), Stefan Monnier, 2015/08/09
- Re: Patches on ffap (mainly for latex buffers), Nicolas Richard, 2015/08/09