emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unsolicited patch to image-mode.el -- "fit to window"


From: martin rudalics
Subject: Re: unsolicited patch to image-mode.el -- "fit to window"
Date: Sat, 25 Jul 2015 10:27:35 +0200

> right, that seems like a good rule to me.  so, i'd tend to leave my code
> with the same pattern used in the rest of the file (i.e., using
> (window-size-pixel-edges)), just for consistency.

I don't understand the "so" ;-)

> (but, even a very
> light breeze would be enough to cause me to change it to use the clearer
> calls, so feel free to so breathe.)

I can't test your patch because I build without image support.  But I
have two questions: (1) Why can't you use `fit-window-to-buffer'?  (2)
If the image appears on a frame alone, can you fit the frame to the
image?  Can `fit-frame-to-buffer' fit the frame to the image?  Both of
these should work, in principle.

martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]